Skip to content

Commit

Permalink
i2c: dln2: Simplify return flow for dln2_i2c_enable
Browse files Browse the repository at this point in the history
This fixes the following kbuild test robot warning:

>> drivers/i2c/busses/i2c-dln2.c:70:1-4: WARNING: end returns can be simplified if negative or 0 value

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
  • Loading branch information
Octavian Purdila authored and Lee Jones committed Nov 19, 2014
1 parent 7ca2b1c commit 9331642
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/i2c/busses/i2c-dln2.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ struct dln2_i2c {

static int dln2_i2c_enable(struct dln2_i2c *dln2, bool enable)
{
int ret;
u16 cmd;
struct {
u8 port;
Expand All @@ -67,11 +66,7 @@ static int dln2_i2c_enable(struct dln2_i2c *dln2, bool enable)
else
cmd = DLN2_I2C_DISABLE;

ret = dln2_transfer_tx(dln2->pdev, cmd, &tx, sizeof(tx));
if (ret < 0)
return ret;

return 0;
return dln2_transfer_tx(dln2->pdev, cmd, &tx, sizeof(tx));
}

static int dln2_i2c_write(struct dln2_i2c *dln2, u8 addr,
Expand Down

0 comments on commit 9331642

Please sign in to comment.