Skip to content

Commit

Permalink
ACPI / RTC: Fix CMOS RTC opregion handler accesses to wrong addresses
Browse files Browse the repository at this point in the history
The value64 parameter is an u64 point that used to transfer the value
for write to CMOS, or used to return the value that's read from CMOS.

The value64 is an u64 point, so don't need get address again. It causes
acpi_cmos_rtc_space_handler always return 0 to reader and didn't write
expected value to CMOS.

Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Cc: 3.11+ <stable@vger.kernel.org> # 3.11+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Lee, Chun-Yi authored and Rafael J. Wysocki committed Sep 8, 2014
1 parent 2ce7598 commit 9389f46
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/acpi/acpi_cmos_rtc.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ acpi_cmos_rtc_space_handler(u32 function, acpi_physical_address address,
void *handler_context, void *region_context)
{
int i;
u8 *value = (u8 *)&value64;
u8 *value = (u8 *)value64;

if (address > 0xff || !value64)
return AE_BAD_PARAMETER;
Expand Down

0 comments on commit 9389f46

Please sign in to comment.