Skip to content

Commit

Permalink
USB: serial: safe-serial: fix up printk() usage
Browse files Browse the repository at this point in the history
The driver was calling printk() directly at startup, which is just
noise.  Switch over to using pr_info() where needed, and get rid of the
totally useless version number that had never ever been incremented.

Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Sep 18, 2012
1 parent 788a661 commit 93ba0f0
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/usb/serial/safe_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
*
*/

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <linux/kernel.h>
#include <linux/errno.h>
Expand All @@ -84,7 +85,6 @@
static bool safe = 1;
static bool padded = CONFIG_USB_SERIAL_SAFE_PADDED;

#define DRIVER_VERSION "v0.1"
#define DRIVER_AUTHOR "sl@lineo.com, tbr@lineo.com, Johan Hovold <jhovold@gmail.com>"
#define DRIVER_DESC "USB Safe Encapsulated Serial"

Expand Down Expand Up @@ -311,13 +311,9 @@ static int __init safe_init(void)
{
int i;

printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
DRIVER_DESC "\n");

/* if we have vendor / product parameters patch them into id list */
if (vendor || product) {
printk(KERN_INFO KBUILD_MODNAME ": vendor: %x product: %x\n",
vendor, product);
pr_info("vendor: %x product: %x\n", vendor, product);

for (i = 0; i < ARRAY_SIZE(id_table); i++) {
if (!id_table[i].idVendor && !id_table[i].idProduct) {
Expand Down

0 comments on commit 93ba0f0

Please sign in to comment.