Skip to content

Commit

Permalink
rxrpc: Fix send in rxrpc_send_data_packet()
Browse files Browse the repository at this point in the history
All the kernel_sendmsg() calls in rxrpc_send_data_packet() need to send
both parts of the iov[] buffer, but one of them does not.  Fix it so that
it does.

Without this, short IPv6 rxrpc DATA packets may be seen that have the rxrpc
header included, but no payload.

Fixes: 5a924b8 ("rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs")
Reported-by: Marc Dionne <marc.dionne@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David Howells authored and David S. Miller committed Feb 22, 2018
1 parent 370c105 commit 93c62c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/rxrpc/output.c
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ int rxrpc_send_data_packet(struct rxrpc_call *call, struct sk_buff *skb,
(char *)&opt, sizeof(opt));
if (ret == 0) {
ret = kernel_sendmsg(conn->params.local->socket, &msg,
iov, 1, iov[0].iov_len);
iov, 2, len);

opt = IPV6_PMTUDISC_DO;
kernel_setsockopt(conn->params.local->socket,
Expand Down

0 comments on commit 93c62c4

Please sign in to comment.