Skip to content

Commit

Permalink
r8169: remove poll_locked logic
Browse files Browse the repository at this point in the history
Disabling napi polling early is well enough.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: Edward Hsu <edward_hsu@realtek.com.tw>
  • Loading branch information
Stephen Hemminger authored and Francois Romieu committed Oct 28, 2007
1 parent 7fab06c commit 93dd79e
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/net/r8169.c
Original file line number Diff line number Diff line change
Expand Up @@ -2991,13 +2991,16 @@ static void rtl8169_down(struct net_device *dev)
{
struct rtl8169_private *tp = netdev_priv(dev);
void __iomem *ioaddr = tp->mmio_addr;
unsigned int poll_locked = 0;
unsigned int intrmask;

rtl8169_delete_timer(dev);

netif_stop_queue(dev);

#ifdef CONFIG_R8169_NAPI
napi_disable(&tp->napi);
#endif

core_down:
spin_lock_irq(&tp->lock);

Expand All @@ -3011,13 +3014,6 @@ static void rtl8169_down(struct net_device *dev)

synchronize_irq(dev->irq);

if (!poll_locked) {
#ifdef CONFIG_R8169_NAPI
napi_disable(&tp->napi);
#endif
poll_locked++;
}

/* Give a racing hard_start_xmit a few cycles to complete. */
synchronize_sched(); /* FIXME: should this be synchronize_irq()? */

Expand Down

0 comments on commit 93dd79e

Please sign in to comment.