Skip to content

Commit

Permalink
net: usb: ax88179_178a: Use linkmode helpers for EEE
Browse files Browse the repository at this point in the history
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Andrew Lunn authored and David S. Miller committed Feb 28, 2024
1 parent 17206c1 commit 93e6da6
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/net/usb/ax88179_178a.c
Original file line number Diff line number Diff line change
Expand Up @@ -676,29 +676,29 @@ ax88179_ethtool_get_eee(struct usbnet *dev, struct ethtool_keee *data)
MDIO_MMD_PCS);
if (val < 0)
return val;
data->supported_u32 = mmd_eee_cap_to_ethtool_sup_t(val);
mii_eee_cap1_mod_linkmode_t(data->supported, val);

/* Get advertisement EEE */
val = ax88179_phy_read_mmd_indirect(dev, MDIO_AN_EEE_ADV,
MDIO_MMD_AN);
if (val < 0)
return val;
data->advertised_u32 = mmd_eee_adv_to_ethtool_adv_t(val);
mii_eee_cap1_mod_linkmode_t(data->advertised, val);

/* Get LP advertisement EEE */
val = ax88179_phy_read_mmd_indirect(dev, MDIO_AN_EEE_LPABLE,
MDIO_MMD_AN);
if (val < 0)
return val;
data->lp_advertised_u32 = mmd_eee_adv_to_ethtool_adv_t(val);
mii_eee_cap1_mod_linkmode_t(data->lp_advertised, val);

return 0;
}

static int
ax88179_ethtool_set_eee(struct usbnet *dev, struct ethtool_keee *data)
{
u16 tmp16 = ethtool_adv_to_mmd_eee_adv_t(data->advertised_u32);
u16 tmp16 = linkmode_to_mii_eee_cap1_t(data->advertised);

return ax88179_phy_write_mmd_indirect(dev, MDIO_AN_EEE_ADV,
MDIO_MMD_AN, tmp16);
Expand Down Expand Up @@ -1663,7 +1663,7 @@ static int ax88179_reset(struct usbnet *dev)
ax88179_disable_eee(dev);

ax88179_ethtool_get_eee(dev, &eee_data);
eee_data.advertised_u32 = 0;
linkmode_zero(eee_data.advertised);
ax88179_ethtool_set_eee(dev, &eee_data);

/* Restart autoneg */
Expand Down

0 comments on commit 93e6da6

Please sign in to comment.