Skip to content

Commit

Permalink
perf top: Switch to non overwrite mode
Browse files Browse the repository at this point in the history
Just like 'perf record'. Warn the user when PERF_RECORD_LOST events
happen.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Jan 29, 2011
1 parent 7bb4115 commit 93fc64f
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions tools/perf/builtin-top.c
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ static void rb_insert_active_sym(struct rb_root *tree, struct sym_entry *se)
rb_insert_color(&se->rb_node, tree);
}

static void print_sym_table(void)
static void print_sym_table(struct perf_session *session)
{
int printed = 0, j;
struct perf_evsel *counter;
Expand Down Expand Up @@ -513,7 +513,6 @@ static void print_sym_table(void)

puts(CONSOLE_CLEAR);

printf("%-*.*s\n", win_width, win_width, graph_dotted_line);
if (!perf_guest) {
printf(" PerfTop:%8.0f irqs/sec kernel:%4.1f%%"
" exact: %4.1f%% [",
Expand Down Expand Up @@ -578,6 +577,12 @@ static void print_sym_table(void)

printf("%-*.*s\n", win_width, win_width, graph_dotted_line);

if (session->hists.stats.total_lost != 0) {
color_fprintf(stdout, PERF_COLOR_RED, "WARNING:");
printf(" LOST %" PRIu64 " events, Check IO/CPU overload\n",
session->hists.stats.total_lost);
}

if (sym_filter_entry) {
show_details(sym_filter_entry);
return;
Expand Down Expand Up @@ -919,7 +924,7 @@ static void *display_thread(void *arg __used)
getc(stdin);

do {
print_sym_table();
print_sym_table(session);
} while (!poll(&stdin_poll, 1, delay_msecs) == 1);

c = getc(stdin);
Expand Down Expand Up @@ -1176,7 +1181,7 @@ static void start_counters(struct perf_evlist *evlist)
}
}

if (perf_evlist__mmap(evlist, cpus, threads, mmap_pages, true) < 0)
if (perf_evlist__mmap(evlist, cpus, threads, mmap_pages, false) < 0)
die("failed to mmap with %d (%s)\n", errno, strerror(errno));
}

Expand Down

0 comments on commit 93fc64f

Please sign in to comment.