Skip to content

Commit

Permalink
irq: irq-keystone: Fix race in installing chained IRQ handler
Browse files Browse the repository at this point in the history
Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/E1Z4z0S-0002Ss-1V@rmk-PC.arm.linux.org.uk
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Russell King authored and Thomas Gleixner committed Jun 18, 2015
1 parent e88d251 commit 9414b6e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/irqchip/irq-keystone.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,7 @@ static int keystone_irq_probe(struct platform_device *pdev)

platform_set_drvdata(pdev, kirq);

irq_set_chained_handler(kirq->irq, keystone_irq_handler);
irq_set_handler_data(kirq->irq, kirq);
irq_set_chained_handler_and_data(kirq->irq, keystone_irq_handler, kirq);

/* clear all source bits */
keystone_irq_writel(kirq, ~0x0);
Expand Down

0 comments on commit 9414b6e

Please sign in to comment.