Skip to content

Commit

Permalink
NFS: Open-code the nfs_kset kset_create_and_add()
Browse files Browse the repository at this point in the history
In preparation to make objects below /sys/fs/nfs namespace aware, we need
to define our own kobj_type for the nfs kset so that we can add the
.child_ns_type member in a following patch.  No functional change here, only
the unrolling of kset_create_and_add().

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
  • Loading branch information
Benjamin Coddington authored and Trond Myklebust committed Jun 19, 2023
1 parent d5082ac commit 943aef2
Showing 1 changed file with 32 additions and 2 deletions.
34 changes: 32 additions & 2 deletions fs/nfs/sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,23 @@ static void nfs_netns_object_release(struct kobject *kobj)
kfree(kobj);
}

static void nfs_kset_release(struct kobject *kobj)
{
struct kset *kset = container_of(kobj, struct kset, kobj);
kfree(kset);
}

static const struct kobj_ns_type_operations *nfs_netns_object_child_ns_type(
const struct kobject *kobj)
{
return &net_ns_type_operations;
}

static struct kobj_type nfs_kset_type = {
.release = nfs_kset_release,
.sysfs_ops = &kobj_sysfs_ops,
};

static struct kobj_type nfs_netns_object_type = {
.release = nfs_netns_object_release,
.sysfs_ops = &kobj_sysfs_ops,
Expand All @@ -55,13 +66,32 @@ static struct kobject *nfs_netns_object_alloc(const char *name,

int nfs_sysfs_init(void)
{
nfs_kset = kset_create_and_add("nfs", NULL, fs_kobj);
int ret;

nfs_kset = kzalloc(sizeof(*nfs_kset), GFP_KERNEL);
if (!nfs_kset)
return -ENOMEM;

ret = kobject_set_name(&nfs_kset->kobj, "nfs");
if (ret) {
kfree(nfs_kset);
return ret;
}

nfs_kset->kobj.parent = fs_kobj;
nfs_kset->kobj.ktype = &nfs_kset_type;
nfs_kset->kobj.kset = NULL;

ret = kset_register(nfs_kset);
if (ret) {
kfree(nfs_kset);
return ret;
}

nfs_net_kobj = nfs_netns_object_alloc("net", nfs_kset, NULL);
if (!nfs_net_kobj) {
kset_unregister(nfs_kset);
nfs_kset = NULL;
kfree(nfs_kset);
return -ENOMEM;
}
return 0;
Expand Down

0 comments on commit 943aef2

Please sign in to comment.