Skip to content

Commit

Permalink
platform_device: use a macro instead of platform_driver_register
Browse files Browse the repository at this point in the history
I found a lot of mistakes using struct platform_driver without owner
so I make a macro instead of the function platform_driver_register.
It can set owner in it, then guys don`t care about module owner again.

Signed-off-by: Libo Chen <libo.chen@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Libo Chen authored and Greg Kroah-Hartman committed Jun 3, 2013
1 parent f494513 commit 9447057
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
8 changes: 5 additions & 3 deletions drivers/base/platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -523,11 +523,13 @@ static void platform_drv_shutdown(struct device *_dev)
}

/**
* platform_driver_register - register a driver for platform-level devices
* __platform_driver_register - register a driver for platform-level devices
* @drv: platform driver structure
*/
int platform_driver_register(struct platform_driver *drv)
int __platform_driver_register(struct platform_driver *drv,
struct module *owner)
{
drv->driver.owner = owner;
drv->driver.bus = &platform_bus_type;
if (drv->probe)
drv->driver.probe = platform_drv_probe;
Expand All @@ -538,7 +540,7 @@ int platform_driver_register(struct platform_driver *drv)

return driver_register(&drv->driver);
}
EXPORT_SYMBOL_GPL(platform_driver_register);
EXPORT_SYMBOL_GPL(__platform_driver_register);

/**
* platform_driver_unregister - unregister a driver for platform-level devices
Expand Down
8 changes: 7 additions & 1 deletion include/linux/platform_device.h
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,13 @@ struct platform_driver {
const struct platform_device_id *id_table;
};

extern int platform_driver_register(struct platform_driver *);
/*
* use a macro to avoid include chaining to get THIS_MODULE
*/
#define platform_driver_register(drv) \
__platform_driver_register(drv, THIS_MODULE)
extern int __platform_driver_register(struct platform_driver *,
struct module *);
extern void platform_driver_unregister(struct platform_driver *);

/* non-hotpluggable platform devices may use this so that probe() and
Expand Down

0 comments on commit 9447057

Please sign in to comment.