Skip to content

Commit

Permalink
netfilter: remove synchronize_net() calls in ip_queue/ip6_queue
Browse files Browse the repository at this point in the history
nf_unregister_queue_handlers() already does a synchronize_rcu()
call, we dont need to do it again in callers.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
  • Loading branch information
Eric Dumazet authored and Patrick McHardy committed Nov 4, 2009
1 parent aa3c487 commit 9481721
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion net/ipv4/netfilter/ip_queue.c
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ cleanup_ipqnl: __maybe_unused
static void __exit ip_queue_fini(void)
{
nf_unregister_queue_handlers(&nfqh);
synchronize_net();

ipq_flush(NULL, 0);

#ifdef CONFIG_SYSCTL
Expand Down
2 changes: 1 addition & 1 deletion net/ipv6/netfilter/ip6_queue.c
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ cleanup_ipqnl: __maybe_unused
static void __exit ip6_queue_fini(void)
{
nf_unregister_queue_handlers(&nfqh);
synchronize_net();

ipq_flush(NULL, 0);

#ifdef CONFIG_SYSCTL
Expand Down

0 comments on commit 9481721

Please sign in to comment.