Skip to content

Commit

Permalink
sched: Remove WARN_ON(!sd) from init_sched_groups_power()
Browse files Browse the repository at this point in the history
sd can't be NULL in init_sched_groups_power() and so checking it for NULL isn't
useful. In case it is required, then also we need to rearrange the code a bit as
we already accessed invalid pointer sd to get sg: sg = sd->groups.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/2bbe633cd74b431c05253a8ce61fdfd5066a531b.1370948150.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Viresh Kumar authored and Ingo Molnar committed Jun 19, 2013
1 parent cd08e92 commit 94c95ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/sched/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -5400,7 +5400,7 @@ static void init_sched_groups_power(int cpu, struct sched_domain *sd)
{
struct sched_group *sg = sd->groups;

WARN_ON(!sd || !sg);
WARN_ON(!sg);

do {
sg->group_weight = cpumask_weight(sched_group_cpus(sg));
Expand Down

0 comments on commit 94c95ba

Please sign in to comment.