Skip to content

Commit

Permalink
drm/amd/display: Remove unnecessary DC_FP_START/DC_FP_END
Browse files Browse the repository at this point in the history
[WHY & HOW]
Remove the unnecessary DC_FP_START/DC_FP_END pair to reduce time in
preempt_disable. It also fixes "BUG: sleeping function called from
invalid context" error messages because of calling kzalloc with
GFP_KERNEL which can sleep.

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Ray Wu <ray.wu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Alex Hung authored and Alex Deucher committed May 5, 2025
1 parent a9cbeb6 commit 94da073
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2114,8 +2114,6 @@ static bool dcn32_resource_construct(
#define REG_STRUCT dccg_regs
dccg_regs_init();

DC_FP_START();

ctx->dc_bios->regs = &bios_regs;

pool->base.res_cap = &res_cap_dcn32;
Expand Down Expand Up @@ -2501,14 +2499,10 @@ static bool dcn32_resource_construct(
if (ASICREV_IS_GC_11_0_3(dc->ctx->asic_id.hw_internal_rev) && (dc->config.sdpif_request_limit_words_per_umc == 0))
dc->config.sdpif_request_limit_words_per_umc = 16;

DC_FP_END();

return true;

create_fail:

DC_FP_END();

dcn32_resource_destruct(pool);

return false;
Expand Down

0 comments on commit 94da073

Please sign in to comment.