Skip to content

Commit

Permalink
x86/amd-iommu: Move inv-dte command building to own function
Browse files Browse the repository at this point in the history
This patch moves command building for the invalidate-dte
command into its own function.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
  • Loading branch information
Joerg Roedel committed Apr 6, 2011
1 parent ded4673 commit 94fe79e
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions arch/x86/kernel/amd_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,13 @@ static void build_completion_wait(struct iommu_cmd *cmd)
CMD_SET_TYPE(cmd, CMD_COMPL_WAIT);
}

static void build_inv_dte(struct iommu_cmd *cmd, u16 devid)
{
memset(cmd, 0, sizeof(*cmd));
cmd->data[0] = devid;
CMD_SET_TYPE(cmd, CMD_INV_DEV_ENTRY);
}

/*
* Writes the command to the IOMMUs command buffer and informs the
* hardware about the new command. Must be called with iommu->lock held.
Expand Down Expand Up @@ -533,10 +540,7 @@ static int iommu_flush_device(struct device *dev)
devid = get_device_id(dev);
iommu = amd_iommu_rlookup_table[devid];

/* Build command */
memset(&cmd, 0, sizeof(cmd));
CMD_SET_TYPE(&cmd, CMD_INV_DEV_ENTRY);
cmd.data[0] = devid;
build_inv_dte(&cmd, devid);

return iommu_queue_command(iommu, &cmd);
}
Expand Down

0 comments on commit 94fe79e

Please sign in to comment.