Skip to content

Commit

Permalink
iio: adc: tsc2046: fix a warning message in tsc2046_adc_update_scan_m…
Browse files Browse the repository at this point in the history
…ode()

These variables are unsigned so the condition can't be less than zero
and the warning message will never be printed.

Fixes: 9374e8f ("iio: adc: add ADC driver for the TI TSC2046 controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YJ+ZuO43TnguY5vq@mwanda
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
Dan Carpenter authored and Jonathan Cameron committed Jun 3, 2021
1 parent 2989df4 commit 9504db5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/iio/adc/ti-tsc2046.c
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ static int tsc2046_adc_update_scan_mode(struct iio_dev *indio_dev,
priv->xfer.len = size;
priv->time_per_scan_us = size * 8 * priv->time_per_bit_ns / NSEC_PER_USEC;

if ((priv->scan_interval_us - priv->time_per_scan_us) < 0)
if (priv->scan_interval_us > priv->time_per_scan_us)
dev_warn(&priv->spi->dev, "The scan interval (%d) is less then calculated scan time (%d)\n",
priv->scan_interval_us, priv->time_per_scan_us);

Expand Down

0 comments on commit 9504db5

Please sign in to comment.