Skip to content

Commit

Permalink
Bluetooth: hci_bcm: add missing tty-device sanity check
Browse files Browse the repository at this point in the history
Make sure to check the tty-device pointer before looking up the sibling
platform device to avoid dereferencing a NULL-pointer when the tty is
one end of a Unix98 pty.

Fixes: 0395ffc ("Bluetooth: hci_bcm: Add PM for BCM devices")
Cc: stable <stable@vger.kernel.org>     # 4.3
Cc: Frederic Danis <frederic.danis@linux.intel.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Johan Hovold authored and Marcel Holtmann committed Apr 12, 2017
1 parent 941825e commit 95065a6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/bluetooth/hci_bcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,9 @@ static int bcm_open(struct hci_uart *hu)

hu->priv = bcm;

if (!hu->tty->dev)
goto out;

mutex_lock(&bcm_device_lock);
list_for_each(p, &bcm_device_list) {
struct bcm_device *dev = list_entry(p, struct bcm_device, list);
Expand All @@ -307,7 +310,7 @@ static int bcm_open(struct hci_uart *hu)
}

mutex_unlock(&bcm_device_lock);

out:
return 0;
}

Expand Down

0 comments on commit 95065a6

Please sign in to comment.