Skip to content

Commit

Permalink
tpm, tpm_tis: Claim locality when interrupts are reenabled on resume
Browse files Browse the repository at this point in the history
In tpm_tis_resume() make sure that the locality has been claimed when
tpm_tis_reenable_interrupts() is called. Otherwise the writings to the
register might not have any effect.

Fixes: 45baa1d ("tpm_tis: Re-enable interrupts upon (S3) resume")
Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Tested-by: Jarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
  • Loading branch information
Lino Sanfilippo authored and Jarkko Sakkinen committed Apr 24, 2023
1 parent 0e06926 commit 955df4f
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions drivers/char/tpm/tpm_tis_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1225,28 +1225,27 @@ int tpm_tis_resume(struct device *dev)
struct tpm_chip *chip = dev_get_drvdata(dev);
int ret;

ret = tpm_tis_request_locality(chip, 0);
if (ret < 0)
return ret;

if (chip->flags & TPM_CHIP_FLAG_IRQ)
tpm_tis_reenable_interrupts(chip);

ret = tpm_pm_resume(dev);
if (ret)
return ret;
goto out;

/*
* TPM 1.2 requires self-test on resume. This function actually returns
* an error code but for unknown reason it isn't handled.
*/
if (!(chip->flags & TPM_CHIP_FLAG_TPM2)) {
ret = tpm_tis_request_locality(chip, 0);
if (ret < 0)
return ret;

if (!(chip->flags & TPM_CHIP_FLAG_TPM2))
tpm1_do_selftest(chip);
out:
tpm_tis_relinquish_locality(chip, 0);

tpm_tis_relinquish_locality(chip, 0);
}

return 0;
return ret;
}
EXPORT_SYMBOL_GPL(tpm_tis_resume);
#endif
Expand Down

0 comments on commit 955df4f

Please sign in to comment.