Skip to content

Commit

Permalink
[SCSI] libsas: remove unused ata_task_resp fields
Browse files Browse the repository at this point in the history
Commit 1e34c83 "[SCSI] libsas: remove spurious sata control register
read/write" removed the routines to fake the presence of the sata
control registers, now remove the unused data structure fields to kill
any remaining confusion.

Acked-by: Jack Wang <jack_wang@usish.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
  • Loading branch information
Dan Williams authored and James Bottomley committed Feb 19, 2012
1 parent 18a4d0a commit 95ac7fd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
4 changes: 0 additions & 4 deletions drivers/scsi/libsas/sas_ata.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,6 @@ static void sas_ata_task_done(struct sas_task *task)
if (unlikely(link->eh_info.err_mask))
qc->flags |= ATA_QCFLAG_FAILED;
}

dev->sata_dev.sstatus = resp->sstatus;
dev->sata_dev.serror = resp->serror;
dev->sata_dev.scontrol = resp->scontrol;
} else {
ac = sas_to_ata_err(stat);
if (ac) {
Expand Down
7 changes: 0 additions & 7 deletions include/scsi/libsas.h
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,6 @@ struct sata_device {
struct ata_port *ap;
struct ata_host ata_host;
struct ata_taskfile tf;
u32 sstatus;
u32 serror;
u32 scontrol;
};

/* ---------- Domain device ---------- */
Expand Down Expand Up @@ -487,10 +484,6 @@ enum exec_status {
struct ata_task_resp {
u16 frame_len;
u8 ending_fis[24]; /* dev to host or data-in */
u32 sstatus;
u32 serror;
u32 scontrol;
u32 sactive;
};

#define SAS_STATUS_BUF_SIZE 96
Expand Down

0 comments on commit 95ac7fd

Please sign in to comment.