Skip to content

Commit

Permalink
ARM: davinci: PM: Do not free useful resources in normal path in 'dav…
Browse files Browse the repository at this point in the history
…inci_pm_init'

It is wrong to iounmap resources in the normal path of davinci_pm_init()

The 3 ioremap'ed fields of 'pm_config' can be accessed later on in other
functions, so we should return 'success' instead of unrolling everything.

Fixes: aa9aa1e ("ARM: davinci: PM: rework init, remove platform device")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
[nsekhar@ti.com: commit message and minor style fixes]
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
  • Loading branch information
Christophe JAILLET authored and Sekhar Nori committed May 17, 2017
1 parent f3f6cc8 commit 95d7c1f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions arch/arm/mach-davinci/pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ int __init davinci_pm_init(void)

suspend_set_ops(&davinci_pm_ops);

return 0;

no_sram_mem:
iounmap(pm_config.ddrpsc_reg_base);
no_ddrpsc_mem:
Expand Down

0 comments on commit 95d7c1f

Please sign in to comment.