Skip to content

Commit

Permalink
selftests/memory-hotplug: Adjust log info for maintainability
Browse files Browse the repository at this point in the history
Redirect misleading error message to /dev/null for
offline_memory_expect_success(), And, add an output
for online->offline test.

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
Acked-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
  • Loading branch information
Zhao Gongyi authored and Shuah Khan committed Oct 7, 2022
1 parent 3e77a49 commit 95e5a91
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,11 @@ echo -e "\t trying to offline $target out of $hotpluggable_num memory block(s):"
for memory in `hotpluggable_online_memory`; do
if [ "$target" -gt 0 ]; then
echo "online->offline memory$memory"
if offline_memory_expect_success $memory; then
if offline_memory_expect_success $memory &>/dev/null; then
target=$(($target - 1))
echo "-> Success"
else
echo "-> Failure"
fi
fi
done
Expand Down Expand Up @@ -267,7 +270,7 @@ prerequisite_extra
echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error
for memory in `hotpluggable_online_memory`; do
if [ $((RANDOM % 100)) -lt $ratio ]; then
offline_memory_expect_success $memory
offline_memory_expect_success $memory &>/dev/null
fi
done

Expand Down

0 comments on commit 95e5a91

Please sign in to comment.