staging: rtl8192e use kmemdup and check its return value

use kmemdup instead of kmalloc and memcpy, and check its return value Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mariux64 · Mar 7, 2011 · 9603ff5 · 9603ff5
1 parent 0875abf
commit 9603ff5
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c
@@ -1564,8 +1564,9 @@ static inline u16 auth_parse(struct sk_buff *skb, u8** challenge, int *chlen)
 
 		if(*(t++) == MFIE_TYPE_CHALLENGE){
 			*chlen = *(t++);
-			*challenge = kmalloc(*chlen, GFP_ATOMIC);
-			memcpy(*challenge, t, *chlen);
+			*challenge = kmemdup(t, *chlen, GFP_ATOMIC);
+			if (!*challenge)
+				return -ENOMEM;
 		}
 	}