Skip to content

Commit

Permalink
drm/armada: register crtc with port
Browse files Browse the repository at this point in the history
Register the CRTC with the port node so that the DRM OF helpers can
find the appropriate CRTC.  This is important so that encoders can
identify their corresponding possible CRTCs.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King committed Jul 11, 2014
1 parent d8c9608 commit 9611cb9
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 4 deletions.
21 changes: 19 additions & 2 deletions drivers/gpu/drm/armada/armada_crtc.c
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,8 @@ static void armada_drm_crtc_destroy(struct drm_crtc *crtc)

writel_relaxed(0, dcrtc->base + LCD_SPU_IRQ_ENA);

of_node_put(dcrtc->crtc.port);

kfree(dcrtc);
}

Expand Down Expand Up @@ -1050,7 +1052,8 @@ static int armada_drm_crtc_create_properties(struct drm_device *dev)
}

int armada_drm_crtc_create(struct drm_device *drm, struct device *dev,
struct resource *res, int irq, const struct armada_variant *variant)
struct resource *res, int irq, const struct armada_variant *variant,
struct device_node *port)
{
struct armada_private *priv = drm->dev_private;
struct armada_crtc *dcrtc;
Expand Down Expand Up @@ -1123,6 +1126,7 @@ int armada_drm_crtc_create(struct drm_device *drm, struct device *dev,

priv->dcrtc[dcrtc->num] = dcrtc;

dcrtc->crtc.port = port;
drm_crtc_init(drm, &dcrtc->crtc, &armada_crtc_funcs);
drm_crtc_helper_add(&dcrtc->crtc, &armada_crtc_helper_funcs);

Expand All @@ -1142,6 +1146,7 @@ armada_lcd_bind(struct device *dev, struct device *master, void *data)
struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
int irq = platform_get_irq(pdev, 0);
const struct armada_variant *variant;
struct device_node *port = NULL;

if (irq < 0)
return irq;
Expand All @@ -1156,15 +1161,27 @@ armada_lcd_bind(struct device *dev, struct device *master, void *data)
variant = (const struct armada_variant *)id->driver_data;
} else {
const struct of_device_id *match;
struct device_node *np, *parent = dev->of_node;

match = of_match_device(dev->driver->of_match_table, dev);
if (!match)
return -ENXIO;

np = of_get_child_by_name(parent, "ports");
if (np)
parent = np;
port = of_get_child_by_name(parent, "port");
of_node_put(np);
if (!port) {
dev_err(dev, "no port node found in %s\n",
parent->full_name);
return -ENXIO;
}

variant = match->data;
}

return armada_drm_crtc_create(drm, dev, res, irq, variant);
return armada_drm_crtc_create(drm, dev, res, irq, variant, port);
}

static void
Expand Down
4 changes: 3 additions & 1 deletion drivers/gpu/drm/armada/armada_crtc.h
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,10 @@ struct armada_crtc {
};
#define drm_to_armada_crtc(c) container_of(c, struct armada_crtc, crtc)

struct device_node;
int armada_drm_crtc_create(struct drm_device *, struct device *,
struct resource *, int, const struct armada_variant *);
struct resource *, int, const struct armada_variant *,
struct device_node *);
void armada_drm_crtc_gamma_set(struct drm_crtc *, u16, u16, u16, int);
void armada_drm_crtc_gamma_get(struct drm_crtc *, u16 *, u16 *, u16 *, int);
void armada_drm_crtc_disable_irq(struct armada_crtc *, u32);
Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/armada/armada_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ static int armada_drm_load(struct drm_device *dev, unsigned long flags)
goto err_kms;

ret = armada_drm_crtc_create(dev, dev->dev, res[n], irq,
variant);
variant, NULL);
if (ret)
goto err_kms;
}
Expand Down

0 comments on commit 9611cb9

Please sign in to comment.