Skip to content

Commit

Permalink
selftests/fpu: move FP code to a separate translation unit
Browse files Browse the repository at this point in the history
This ensures no compiler-generated floating-point code can appear outside
kernel_fpu_{begin,end}() sections, and some architectures enforce this
separation.

Link: https://lkml.kernel.org/r/20240329072441.591471-15-samuel.holland@sifive.com
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christian König <christian.koenig@amd.com> 
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Borislav Petkov (AMD) <bp@alien8.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nicolas Schier <nicolas@fjasle.eu>
Cc: Palmer Dabbelt <palmer@rivosinc.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: WANG Xuerui <git@xen0n.name>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
Samuel Holland authored and Andrew Morton committed May 19, 2024
1 parent a28e4b6 commit 9613736
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 32 deletions.
3 changes: 2 additions & 1 deletion lib/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ FPU_CFLAGS += $(call cc-option,-msse -mpreferred-stack-boundary=3,-mpreferred-st
endif

obj-$(CONFIG_TEST_FPU) += test_fpu.o
CFLAGS_test_fpu.o += $(FPU_CFLAGS)
test_fpu-y := test_fpu_glue.o test_fpu_impl.o
CFLAGS_test_fpu_impl.o += $(FPU_CFLAGS)

# Some KUnit files (hooks.o) need to be built-in even when KUnit is a module,
# so we can't just use obj-$(CONFIG_KUNIT).
Expand Down
8 changes: 8 additions & 0 deletions lib/test_fpu.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0+ */

#ifndef _LIB_TEST_FPU_H
#define _LIB_TEST_FPU_H

int test_fpu(void);

#endif
32 changes: 1 addition & 31 deletions lib/test_fpu.c → lib/test_fpu_glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,37 +19,7 @@
#include <linux/debugfs.h>
#include <asm/fpu/api.h>

static int test_fpu(void)
{
/*
* This sequence of operations tests that rounding mode is
* to nearest and that denormal numbers are supported.
* Volatile variables are used to avoid compiler optimizing
* the calculations away.
*/
volatile double a, b, c, d, e, f, g;

a = 4.0;
b = 1e-15;
c = 1e-310;

/* Sets precision flag */
d = a + b;

/* Result depends on rounding mode */
e = a + b / 2;

/* Denormal and very large values */
f = b / c;

/* Depends on denormal support */
g = a + c * f;

if (d > a && e > a && g > a)
return 0;
else
return -EINVAL;
}
#include "test_fpu.h"

static int test_fpu_get(void *data, u64 *val)
{
Expand Down
37 changes: 37 additions & 0 deletions lib/test_fpu_impl.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// SPDX-License-Identifier: GPL-2.0+

#include <linux/errno.h>

#include "test_fpu.h"

int test_fpu(void)
{
/*
* This sequence of operations tests that rounding mode is
* to nearest and that denormal numbers are supported.
* Volatile variables are used to avoid compiler optimizing
* the calculations away.
*/
volatile double a, b, c, d, e, f, g;

a = 4.0;
b = 1e-15;
c = 1e-310;

/* Sets precision flag */
d = a + b;

/* Result depends on rounding mode */
e = a + b / 2;

/* Denormal and very large values */
f = b / c;

/* Depends on denormal support */
g = a + c * f;

if (d > a && e > a && g > a)
return 0;
else
return -EINVAL;
}

0 comments on commit 9613736

Please sign in to comment.