Skip to content

Commit

Permalink
dmaengine: ti: omap-dma: Add cleanup in omap_dma_probe()
Browse files Browse the repository at this point in the history
If devm_request_irq() fails to disable all interrupts, no cleanup is
performed before retuning the error. To fix this issue, invoke
omap_dma_free() to do the cleanup.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/1565938570-7528-1-git-send-email-wenwen@cs.uga.edu
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Wenwen Wang authored and Vinod Koul committed Aug 20, 2019
1 parent 2c231c0 commit 962411b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/dma/ti/omap-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -1540,8 +1540,10 @@ static int omap_dma_probe(struct platform_device *pdev)

rc = devm_request_irq(&pdev->dev, irq, omap_dma_irq,
IRQF_SHARED, "omap-dma-engine", od);
if (rc)
if (rc) {
omap_dma_free(od);
return rc;
}
}

if (omap_dma_glbl_read(od, CAPS_0) & CAPS_0_SUPPORT_LL123)
Expand Down

0 comments on commit 962411b

Please sign in to comment.