Skip to content

Commit

Permalink
spi: spi-topcliff-pch: Remove some dead code
Browse files Browse the repository at this point in the history
Since commit 0d35773 ("spi: spi-topcliff-pch: Remove deprecated
create_singlethread_workqueue"), 'retval' is no more used in this function.

So some now dead code can be removed.
Also axe a debug message which looks useless now.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Christophe JAILLET authored and Mark Brown committed Nov 21, 2016
1 parent 1001354 commit 9677e7d
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions drivers/spi/spi-topcliff-pch.c
Original file line number Diff line number Diff line change
Expand Up @@ -1268,27 +1268,16 @@ static void pch_spi_free_resources(struct pch_spi_board_data *board_dat,
static int pch_spi_get_resources(struct pch_spi_board_data *board_dat,
struct pch_spi_data *data)
{
int retval = 0;

dev_dbg(&board_dat->pdev->dev, "%s ENTRY\n", __func__);


/* reset PCH SPI h/w */
pch_spi_reset(data->master);
dev_dbg(&board_dat->pdev->dev,
"%s pch_spi_reset invoked successfully\n", __func__);

dev_dbg(&board_dat->pdev->dev, "%s data->irq_reg_sts=true\n", __func__);

if (retval != 0) {
dev_err(&board_dat->pdev->dev,
"%s FAIL:invoking pch_spi_free_resources\n", __func__);
pch_spi_free_resources(board_dat, data);
}

dev_dbg(&board_dat->pdev->dev, "%s Return=%d\n", __func__, retval);

return retval;
return 0;
}

static void pch_free_dma_buf(struct pch_spi_board_data *board_dat,
Expand Down

0 comments on commit 9677e7d

Please sign in to comment.