Skip to content

Commit

Permalink
drm/i915/selftests: Tweak the tolerance for clock ticks to 12.5%
Browse files Browse the repository at this point in the history
Give a small bump for our tolerance on comparing the expected vs
measured clock ticks/time from 10% to 12.5% to accommodate a bad result
on Sandybridge that was off by 10.3%. Hopefully, that is the worst we
will see.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1802
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200428114307.5153-1-chris@chris-wilson.co.uk
  • Loading branch information
Chris Wilson committed Apr 28, 2020
1 parent d631461 commit 96a4faf
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/gpu/drm/i915/gt/selftest_rps.c
Original file line number Diff line number Diff line change
Expand Up @@ -312,15 +312,15 @@ int live_rps_clock_interval(void *arg)
engine->name, cycles, time, ktime_to_ns(dt), expected,
gt->clock_frequency / 1000);

if (10 * time < 9 * ktime_to_ns(dt) ||
10 * time > 11 * ktime_to_ns(dt)) {
if (10 * time < 8 * ktime_to_ns(dt) ||
8 * time > 10 * ktime_to_ns(dt)) {
pr_err("%s: rps clock time does not match walltime!\n",
engine->name);
err = -EINVAL;
}

if (10 * expected < 9 * cycles ||
10 * expected > 11 * cycles) {
if (10 * expected < 8 * cycles ||
8 * expected > 10 * cycles) {
pr_err("%s: walltime does not match rps clock ticks!\n",
engine->name);
err = -EINVAL;
Expand Down

0 comments on commit 96a4faf

Please sign in to comment.