Skip to content

Commit

Permalink
mmiotrace: code style cleanups
Browse files Browse the repository at this point in the history
From c2da03771e29159627c5c7b9509ec70bce9f91ee Mon Sep 17 00:00:00 2001
From: Pekka Paalanen <pq@iki.fi>
Date: Mon, 28 Apr 2008 21:25:22 +0300

Signed-off-by: Pekka Paalanen <pq@iki.fi>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Pekka Paalanen authored and Thomas Gleixner committed May 24, 2008
1 parent 6f6f394 commit 970e6fa
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 12 deletions.
4 changes: 2 additions & 2 deletions arch/x86/mm/kmmio.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
#include <linux/percpu.h>
#include <linux/kdebug.h>
#include <linux/mutex.h>
#include <asm/io.h>
#include <linux/io.h>
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
#include <asm/errno.h>
#include <linux/errno.h>
#include <asm/debugreg.h>
#include <linux/mmiotrace.h>

Expand Down
7 changes: 3 additions & 4 deletions arch/x86/mm/mmio-mod.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#include <linux/module.h>
#include <linux/debugfs.h>
#include <linux/uaccess.h>
#include <asm/io.h>
#include <linux/io.h>
#include <linux/version.h>
#include <linux/kallsyms.h>
#include <asm/pgtable.h>
Expand Down Expand Up @@ -418,11 +418,10 @@ static void enter_uniprocessor(void)

for_each_cpu_mask(cpu, downed_cpus) {
err = cpu_down(cpu);
if (!err) {
if (!err)
pr_info(NAME "CPU%d is down.\n", cpu);
} else {
else
pr_err(NAME "Error taking CPU%d down: %d\n", cpu, err);
}
}
if (num_online_cpus() > 1)
pr_warning(NAME "multiple CPUs still online, "
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/mm/testmmiotrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Written by Pekka Paalanen, 2008 <pq@iki.fi>
*/
#include <linux/module.h>
#include <asm/io.h>
#include <linux/io.h>

#define MODULE_NAME "testmmiotrace"

Expand Down
6 changes: 1 addition & 5 deletions include/linux/mmiotrace.h
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
#ifndef MMIOTRACE_H
#define MMIOTRACE_H

#include <asm/types.h>

#ifdef __KERNEL__
#include <linux/types.h>

#include <linux/list.h>

Expand Down Expand Up @@ -84,6 +82,4 @@ extern void disable_mmiotrace(void);
extern void mmio_trace_rw(struct mmiotrace_rw *rw);
extern void mmio_trace_mapping(struct mmiotrace_map *map);

#endif /* __KERNEL__ */

#endif /* MMIOTRACE_H */

0 comments on commit 970e6fa

Please sign in to comment.