Skip to content

Commit

Permalink
x86: signal: intrroduce get_sigframe() and replace get_sigstack()
Browse files Browse the repository at this point in the history
Impact: cleanup

Introduce get_sigframe() like 32-bit to replace get_sigstack().
Move the i387 stuff into get_sigframe().

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Hiroshi Shimamoto authored and Ingo Molnar committed Feb 28, 2009
1 parent 144b071 commit 97286a2
Showing 1 changed file with 19 additions and 13 deletions.
32 changes: 19 additions & 13 deletions arch/x86/kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -392,18 +392,32 @@ static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
* Determine which stack to use..
*/
static void __user *
get_stack(struct k_sigaction *ka, unsigned long sp, unsigned long size)
get_sigframe(struct k_sigaction *ka, struct pt_regs *regs, size_t frame_size,
void __user **fpstate)
{
/* Default to using normal stack - redzone*/
sp -= 128;
unsigned long sp;

/* Default to using normal stack - redzone */
sp = regs->sp - 128;

/* This is the X/Open sanctioned signal stack switching. */
if (ka->sa.sa_flags & SA_ONSTACK) {
if (sas_ss_flags(sp) == 0)
sp = current->sas_ss_sp + current->sas_ss_size;
}

return (void __user *)round_down(sp - size, 64);
if (used_math()) {
sp -= sig_xstate_size;
*fpstate = (void __user *)round_down(sp, 64);
if (save_i387_xstate(*fpstate) < 0)
return (void __user *) -1L;

sp -= frame_size;
return (void __user *)round_down(sp, 16) - 8;
}

sp -= frame_size;
return (void __user *)round_down(sp, 64) - 8;
}

static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
Expand All @@ -414,15 +428,7 @@ static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
int err = 0;
struct task_struct *me = current;

if (used_math()) {
fp = get_stack(ka, regs->sp, sig_xstate_size);
frame = (void __user *)round_down(
(unsigned long)fp - sizeof(struct rt_sigframe), 16) - 8;

if (save_i387_xstate(fp) < 0)
return -EFAULT;
} else
frame = get_stack(ka, regs->sp, sizeof(struct rt_sigframe)) - 8;
frame = get_sigframe(ka, regs, sizeof(struct rt_sigframe), &fp);

if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame)))
return -EFAULT;
Expand Down

0 comments on commit 97286a2

Please sign in to comment.