Skip to content

Commit

Permalink
r8169: improve handling CPCMD_MASK
Browse files Browse the repository at this point in the history
It's sufficient to do the masking once in probe() for clearing
unwanted bits that may have been set by the BIOS.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Apr 27, 2020
1 parent 45c9cbe commit 975e850
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/ethernet/realtek/r8169_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -3845,7 +3845,6 @@ static void rtl_hw_start(struct rtl8169_private *tp)
{
rtl_unlock_config_regs(tp);

tp->cp_cmd &= CPCMD_MASK;
RTL_W16(tp, CPlusCmd, tp->cp_cmd);

if (tp->mac_version <= RTL_GIGA_MAC_VER_06)
Expand Down Expand Up @@ -5424,7 +5423,7 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)

tp->mac_version = chipset;

tp->cp_cmd = RTL_R16(tp, CPlusCmd);
tp->cp_cmd = RTL_R16(tp, CPlusCmd) & CPCMD_MASK;

if (sizeof(dma_addr_t) > 4 && tp->mac_version >= RTL_GIGA_MAC_VER_18 &&
!dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)))
Expand Down

0 comments on commit 975e850

Please sign in to comment.