Skip to content

Commit

Permalink
mtip32xx: fix user_buffer check in exec_drive_command
Browse files Browse the repository at this point in the history
Current user_buffer check is incorrect and causes hdparm to fail

# hdparm -I /dev/rssda
 HDIO_DRIVE_CMD(identify) failed: Input/output error

/dev/rssda:

Patching linux-3.6-rc5 hdparm works as expected

# hdparm -I /dev/rssda
/dev/rssda:

ATA device, with non-removable media
	Model Number:       DELL_P320h-MTFDGAL350SAH
	Serial Number:      00000000121302025F01
	Firmware Revision:  B1442808
<snip>

Reported-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: David Milburn <dmilburn@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
David Milburn authored and Jens Axboe committed Sep 12, 2012
1 parent ac64e65 commit 97651ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/block/mtip32xx/mtip32xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1904,7 +1904,7 @@ static int exec_drive_command(struct mtip_port *port, u8 *command,
int rv = 0, xfer_sz = command[3];

if (xfer_sz) {
if (user_buffer)
if (!user_buffer)
return -EFAULT;

buf = dmam_alloc_coherent(&port->dd->pdev->dev,
Expand Down

0 comments on commit 97651ea

Please sign in to comment.