Skip to content

Commit

Permalink
net: phy: mxl-gpy: disable interrupts on GPY215 by default
Browse files Browse the repository at this point in the history
The interrupts on the GPY215B and GPY215C are broken and the only viable
fix is to disable them altogether. There is still the possibilty to
opt-in via the device tree.

Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
  • Loading branch information
Michael Walle authored and Paolo Abeni committed Jan 10, 2023
1 parent 7d88586 commit 97a89ed
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/net/phy/mxl-gpy.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <linux/mutex.h>
#include <linux/phy.h>
#include <linux/polynomial.h>
#include <linux/property.h>
#include <linux/netdevice.h>

/* PHY ID */
Expand Down Expand Up @@ -292,6 +293,10 @@ static int gpy_probe(struct phy_device *phydev)
phydev->priv = priv;
mutex_init(&priv->mbox_lock);

if (gpy_has_broken_mdint(phydev) &&
!device_property_present(dev, "maxlinear,use-broken-interrupts"))
phydev->dev_flags |= PHY_F_NO_IRQ;

fw_version = phy_read(phydev, PHY_FWV);
if (fw_version < 0)
return fw_version;
Expand Down

0 comments on commit 97a89ed

Please sign in to comment.