Skip to content

Commit

Permalink
workqueue: prepare for more tracepoints
Browse files Browse the repository at this point in the history
Define workqueue_work event class and use it for workqueue_execute_end
trace point.  Also, move trace/events/workqueue.h include downwards
such that all struct definitions are visible to it.  This is to
prepare for more tracepoints and doesn't cause any functional change.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
  • Loading branch information
Tejun Heo committed Oct 5, 2010
1 parent 0938349 commit 97bd234
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 16 deletions.
32 changes: 19 additions & 13 deletions include/trace/events/workqueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,54 +7,60 @@
#include <linux/tracepoint.h>
#include <linux/workqueue.h>

/**
* workqueue_execute_start - called immediately before the workqueue callback
* @work: pointer to struct work_struct
*
* Allows to track workqueue execution.
*/
TRACE_EVENT(workqueue_execute_start,
DECLARE_EVENT_CLASS(workqueue_work,

TP_PROTO(struct work_struct *work),

TP_ARGS(work),

TP_STRUCT__entry(
__field( void *, work )
__field( void *, function)
),

TP_fast_assign(
__entry->work = work;
__entry->function = work->func;
),

TP_printk("work struct %p: function %pf", __entry->work, __entry->function)
TP_printk("work struct %p", __entry->work)
);

/**
* workqueue_execute_end - called immediately before the workqueue callback
* workqueue_execute_start - called immediately before the workqueue callback
* @work: pointer to struct work_struct
*
* Allows to track workqueue execution.
*/
TRACE_EVENT(workqueue_execute_end,
TRACE_EVENT(workqueue_execute_start,

TP_PROTO(struct work_struct *work),

TP_ARGS(work),

TP_STRUCT__entry(
__field( void *, work )
__field( void *, function)
),

TP_fast_assign(
__entry->work = work;
__entry->function = work->func;
),

TP_printk("work struct %p", __entry->work)
TP_printk("work struct %p: function %pf", __entry->work, __entry->function)
);

/**
* workqueue_execute_end - called immediately before the workqueue callback
* @work: pointer to struct work_struct
*
* Allows to track workqueue execution.
*/
DEFINE_EVENT(workqueue_work, workqueue_execute_end,

TP_PROTO(struct work_struct *work),

TP_ARGS(work)
);

#endif /* _TRACE_WORKQUEUE_H */

Expand Down
6 changes: 3 additions & 3 deletions kernel/workqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@
#include <linux/lockdep.h>
#include <linux/idr.h>

#define CREATE_TRACE_POINTS
#include <trace/events/workqueue.h>

#include "workqueue_sched.h"

enum {
Expand Down Expand Up @@ -257,6 +254,9 @@ EXPORT_SYMBOL_GPL(system_long_wq);
EXPORT_SYMBOL_GPL(system_nrt_wq);
EXPORT_SYMBOL_GPL(system_unbound_wq);

#define CREATE_TRACE_POINTS
#include <trace/events/workqueue.h>

#define for_each_busy_worker(worker, i, pos, gcwq) \
for (i = 0; i < BUSY_WORKER_HASH_SIZE; i++) \
hlist_for_each_entry(worker, pos, &gcwq->busy_hash[i], hentry)
Expand Down

0 comments on commit 97bd234

Please sign in to comment.