Skip to content

Commit

Permalink
net: usb: aqc111: Initialize wol_cfg with memset in aqc111_suspend
Browse files Browse the repository at this point in the history
Clang warns:

drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
initialization of subobject [-Wmissing-braces]
                struct aqc111_wol_cfg wol_cfg = { 0 };
                                                  ^
                                                  {}
1 warning generated.

Use memset to initialize the object to take compiler instrumentation out
of the equation.

Fixes: e58ba45 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Nathan Chancellor authored and David S. Miller committed Dec 1, 2018
1 parent 315c9e8 commit 97e6c85
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/net/usb/aqc111.c
Original file line number Diff line number Diff line change
Expand Up @@ -1323,7 +1323,9 @@ static int aqc111_suspend(struct usb_interface *intf, pm_message_t message)
1, 1, &reg8);

if (aqc111_data->wol_flags) {
struct aqc111_wol_cfg wol_cfg = { 0 };
struct aqc111_wol_cfg wol_cfg;

memset(&wol_cfg, 0, sizeof(struct aqc111_wol_cfg));

aqc111_data->phy_cfg |= AQ_WOL;
ether_addr_copy(wol_cfg.hw_addr, dev->net->dev_addr);
Expand Down

0 comments on commit 97e6c85

Please sign in to comment.