Skip to content

Commit

Permalink
perf tools: Keep group information
Browse files Browse the repository at this point in the history
Add a few of group-related field in struct perf_{evlist,evsel} so that
the group information in a evlist can be known easily.  It only counts
groups which have more than 1 members since leader-only groups are
treated as non-group events.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1358845787-1350-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Namhyung Kim authored and Arnaldo Carvalho de Melo committed Jan 31, 2013
1 parent 0de233b commit 97f63e4
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tools/perf/util/evlist.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ void __perf_evlist__set_leader(struct list_head *list)
struct perf_evsel *evsel, *leader;

leader = list_entry(list->next, struct perf_evsel, node);
evsel = list_entry(list->prev, struct perf_evsel, node);

leader->nr_members = evsel->idx - leader->idx + 1;

list_for_each_entry(evsel, list, node) {
if (evsel != leader)
Expand All @@ -126,8 +129,10 @@ void __perf_evlist__set_leader(struct list_head *list)

void perf_evlist__set_leader(struct perf_evlist *evlist)
{
if (evlist->nr_entries)
if (evlist->nr_entries) {
evlist->nr_groups = evlist->nr_entries > 1 ? 1 : 0;
__perf_evlist__set_leader(&evlist->entries);
}
}

int perf_evlist__add_default(struct perf_evlist *evlist)
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/evlist.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ struct perf_evlist {
struct list_head entries;
struct hlist_head heads[PERF_EVLIST__HLIST_SIZE];
int nr_entries;
int nr_groups;
int nr_fds;
int nr_mmaps;
int mmap_len;
Expand Down
6 changes: 6 additions & 0 deletions tools/perf/util/evsel.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ struct perf_evsel {
bool needs_swap;
/* parse modifier helper */
int exclude_GH;
int nr_members;
struct perf_evsel *leader;
char *group_name;
};
Expand Down Expand Up @@ -259,4 +260,9 @@ bool perf_evsel__fallback(struct perf_evsel *evsel, int err,
int perf_evsel__open_strerror(struct perf_evsel *evsel,
struct perf_target *target,
int err, char *msg, size_t size);

static inline int perf_evsel__group_idx(struct perf_evsel *evsel)
{
return evsel->idx - evsel->leader->idx;
}
#endif /* __PERF_EVSEL_H */
1 change: 1 addition & 0 deletions tools/perf/util/parse-events.c
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,7 @@ int parse_events(struct perf_evlist *evlist, const char *str)
if (!ret) {
int entries = data.idx - evlist->nr_entries;
perf_evlist__splice_list_tail(evlist, &data.list, entries);
evlist->nr_groups += data.nr_groups;
return 0;
}

Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/parse-events.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ struct parse_events_term {
struct parse_events_evlist {
struct list_head list;
int idx;
int nr_groups;
};

struct parse_events_terms {
Expand Down
10 changes: 10 additions & 0 deletions tools/perf/util/parse-events.y
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ do { \
YYABORT; \
} while (0)

static inc_group_count(struct list_head *list,
struct parse_events_evlist *data)
{
/* Count groups only have more than 1 members */
if (!list_is_last(list->next, list))
data->nr_groups++;
}

%}

%token PE_START_EVENTS PE_START_TERMS
Expand Down Expand Up @@ -123,6 +131,7 @@ PE_NAME '{' events '}'
{
struct list_head *list = $3;

inc_group_count(list, _data);
parse_events__set_leader($1, list);
$$ = list;
}
Expand All @@ -131,6 +140,7 @@ PE_NAME '{' events '}'
{
struct list_head *list = $2;

inc_group_count(list, _data);
parse_events__set_leader(NULL, list);
$$ = list;
}
Expand Down

0 comments on commit 97f63e4

Please sign in to comment.