Skip to content

Commit

Permalink
i2c: designware: Drop return value from dw_i2c_of_configure()
Browse files Browse the repository at this point in the history
dw_i2c_of_configure() is called without checking of the returned
value, hence just drop it by converting to void.

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
  • Loading branch information
Andy Shevchenko authored and Andi Shyti committed Sep 9, 2024
1 parent 5674e08 commit 982959f
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/i2c/busses/i2c-designware-platdrv.c
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ static int mscc_twi_set_sda_hold_time(struct dw_i2c_dev *dev)
return 0;
}

static int dw_i2c_of_configure(struct platform_device *pdev)
static void dw_i2c_of_configure(struct platform_device *pdev)
{
struct dw_i2c_dev *dev = platform_get_drvdata(pdev);

Expand All @@ -123,18 +123,15 @@ static int dw_i2c_of_configure(struct platform_device *pdev)
default:
break;
}

return 0;
}
#else
static int bt1_i2c_request_regs(struct dw_i2c_dev *dev)
{
return -ENODEV;
}

static inline int dw_i2c_of_configure(struct platform_device *pdev)
static inline void dw_i2c_of_configure(struct platform_device *pdev)
{
return -ENODEV;
}
#endif

Expand Down

0 comments on commit 982959f

Please sign in to comment.