Skip to content

Commit

Permalink
pull handling of . and .. into inlined helper
Browse files Browse the repository at this point in the history
getting LOOKUP_RCU checks out of link_path_walk()...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Mar 14, 2011
1 parent 7bc055d commit 9856fa1
Showing 1 changed file with 16 additions and 14 deletions.
30 changes: 16 additions & 14 deletions fs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -1318,6 +1318,18 @@ static inline int may_lookup(struct nameidata *nd)
return exec_permission(nd->inode, 0);
}

static inline int handle_dots(struct nameidata *nd, int type)
{
if (type == LAST_DOTDOT) {
if (nd->flags & LOOKUP_RCU) {
if (follow_dotdot_rcu(nd))
return -ECHILD;
} else
follow_dotdot(nd);
}
return 0;
}

/*
* Name resolution.
* This is the basic name resolution function, turning a pathname into
Expand Down Expand Up @@ -1393,13 +1405,8 @@ static int link_path_walk(const char *name, struct nameidata *nd)
* parent relationships.
*/
if (unlikely(type != LAST_NORM)) {
if (type == LAST_DOTDOT) {
if (nd->flags & LOOKUP_RCU) {
if (follow_dotdot_rcu(nd))
return -ECHILD;
} else
follow_dotdot(nd);
}
if (handle_dots(nd, type))
return -ECHILD;
continue;
}

Expand Down Expand Up @@ -1434,13 +1441,8 @@ static int link_path_walk(const char *name, struct nameidata *nd)
if (lookup_flags & LOOKUP_PARENT)
goto lookup_parent;
if (unlikely(type != LAST_NORM)) {
if (type == LAST_DOTDOT) {
if (nd->flags & LOOKUP_RCU) {
if (follow_dotdot_rcu(nd))
return -ECHILD;
} else
follow_dotdot(nd);
}
if (handle_dots(nd, type))
return -ECHILD;
return 0;
}
err = do_lookup(nd, &this, &next, &inode);
Expand Down

0 comments on commit 9856fa1

Please sign in to comment.