Skip to content

Commit

Permalink
itimer: Use printk_once instead of WARN_ONCE
Browse files Browse the repository at this point in the history
David pointed out, that WARN_ONCE() to report usage of an deprecated
misfeature make folks unhappy. Use printk_once() instead.

Andrew told me to stop grumbling and to remove the silly typecast
while touching the file.

Reported-by: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Thomas Gleixner committed Apr 10, 2012
1 parent 6f10392 commit 9886f44
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions kernel/itimer.c
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,10 @@ SYSCALL_DEFINE3(setitimer, int, which, struct itimerval __user *, value,
if(copy_from_user(&set_buffer, value, sizeof(set_buffer)))
return -EFAULT;
} else {
memset((char *) &set_buffer, 0, sizeof(set_buffer));
WARN_ONCE(1, "setitimer: new_value pointer is NULL."
" Misfeature support will be removed\n");
memset(&set_buffer, 0, sizeof(set_buffer));
printk_once(KERN_WARNING "%s calls setitimer() with new_value NULL pointer."
" Misfeature support will be removed\n",
current->comm);
}

error = do_setitimer(which, &set_buffer, ovalue ? &get_buffer : NULL);
Expand Down

0 comments on commit 9886f44

Please sign in to comment.