Skip to content

Commit

Permalink
net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop p…
Browse files Browse the repository at this point in the history
…rofiles

dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yang Wei authored and David S. Miller committed Feb 7, 2019
1 parent 7c3850a commit 98fcd70
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/sun/cassini.c
Original file line number Diff line number Diff line change
Expand Up @@ -1898,7 +1898,7 @@ static inline void cas_tx_ringN(struct cas *cp, int ring, int limit)
cp->net_stats[ring].tx_packets++;
cp->net_stats[ring].tx_bytes += skb->len;
spin_unlock(&cp->stat_lock[ring]);
dev_kfree_skb_irq(skb);
dev_consume_skb_irq(skb);
}
cp->tx_old[ring] = entry;

Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ethernet/sun/sunbmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ static void bigmac_tx(struct bigmac *bp)

DTX(("skb(%p) ", skb));
bp->tx_skbs[elem] = NULL;
dev_kfree_skb_irq(skb);
dev_consume_skb_irq(skb);

elem = NEXT_TX(elem);
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ethernet/sun/sunhme.c
Original file line number Diff line number Diff line change
Expand Up @@ -1962,7 +1962,7 @@ static void happy_meal_tx(struct happy_meal *hp)
this = &txbase[elem];
}

dev_kfree_skb_irq(skb);
dev_consume_skb_irq(skb);
dev->stats.tx_packets++;
}
hp->tx_old = elem;
Expand Down

0 comments on commit 98fcd70

Please sign in to comment.