Skip to content

Commit

Permalink
Merge branch 'locking/nmi' into locking/core, to pick up completed to…
Browse files Browse the repository at this point in the history
…pic branch

Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Ingo Molnar committed Aug 3, 2020
2 parents a68415c + ed00495 commit 992414a
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
3 changes: 3 additions & 0 deletions arch/x86/Kconfig.debug
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
config TRACE_IRQFLAGS_SUPPORT
def_bool y

config TRACE_IRQFLAGS_NMI_SUPPORT
def_bool y

config EARLY_PRINTK_USB
bool

Expand Down
8 changes: 7 additions & 1 deletion kernel/locking/lockdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -3714,6 +3714,9 @@ void noinstr lockdep_hardirqs_on(unsigned long ip)
* and not rely on hardware state like normal interrupts.
*/
if (unlikely(in_nmi())) {
if (!IS_ENABLED(CONFIG_TRACE_IRQFLAGS_NMI))
return;

/*
* Skip:
* - recursion check, because NMI can hit lockdep;
Expand Down Expand Up @@ -3773,7 +3776,10 @@ void noinstr lockdep_hardirqs_off(unsigned long ip)
* they will restore the software state. This ensures the software
* state is consistent inside NMIs as well.
*/
if (unlikely(!in_nmi() && (current->lockdep_recursion & LOCKDEP_RECURSION_MASK)))
if (in_nmi()) {
if (!IS_ENABLED(CONFIG_TRACE_IRQFLAGS_NMI))
return;
} else if (current->lockdep_recursion & LOCKDEP_RECURSION_MASK)
return;

/*
Expand Down
6 changes: 6 additions & 0 deletions lib/Kconfig.debug
Original file line number Diff line number Diff line change
Expand Up @@ -1326,11 +1326,17 @@ config WW_MUTEX_SELFTEST
endmenu # lock debugging

config TRACE_IRQFLAGS
depends on TRACE_IRQFLAGS_SUPPORT
bool
help
Enables hooks to interrupt enabling and disabling for
either tracing or lock debugging.

config TRACE_IRQFLAGS_NMI
def_bool y
depends on TRACE_IRQFLAGS
depends on TRACE_IRQFLAGS_NMI_SUPPORT

config STACKTRACE
bool "Stack backtrace support"
depends on STACKTRACE_SUPPORT
Expand Down

0 comments on commit 992414a

Please sign in to comment.