Skip to content

Commit

Permalink
ASoC: max98363: Remove cache defaults for volatile registers
Browse files Browse the repository at this point in the history
The max98363 driver provides cache defaults for a number of volatile
registers. This is not meaningful, the cache values will never be used so
at best they will just consume memory and at worst they will be used in
preference to real values from the device, remove them.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230609-asoc-mx98363-volatile-v1-1-7acad55f5dd6@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Mark Brown committed Jun 19, 2023
1 parent 424a64a commit 997905d
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions sound/soc/codecs/max98363.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@
#include "max98363.h"

static struct reg_default max98363_reg[] = {
{MAX98363_R2001_INTR_RAW, 0x0},
{MAX98363_R2003_INTR_STATE, 0x0},
{MAX98363_R2005_INTR_FALG, 0x0},
{MAX98363_R2007_INTR_EN, 0x0},
{MAX98363_R2009_INTR_CLR, 0x0},
{MAX98363_R2021_ERR_MON_CTRL, 0x0},
{MAX98363_R2022_SPK_MON_THRESH, 0x0},
{MAX98363_R2023_SPK_MON_DURATION, 0x0},
Expand All @@ -28,7 +23,6 @@ static struct reg_default max98363_reg[] = {
{MAX98363_R2040_AMP_VOL, 0x0},
{MAX98363_R2041_AMP_GAIN, 0x5},
{MAX98363_R2042_DSP_CFG, 0x0},
{MAX98363_R21FF_REV_ID, 0x0},
};

static bool max98363_readable_register(struct device *dev, unsigned int reg)
Expand Down

0 comments on commit 997905d

Please sign in to comment.