Skip to content

Commit

Permalink
eeprom: at24: Annotate struct at24_data with __counted_by
Browse files Browse the repository at this point in the history
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct at24_data.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
  • Loading branch information
Kees Cook authored and Bartosz Golaszewski committed Sep 25, 2023
1 parent 4cdc5db commit 997a29b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/misc/eeprom/at24.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ struct at24_data {
* them for us.
*/
u8 bank_addr_shift;
struct regmap *client_regmaps[];
struct regmap *client_regmaps[] __counted_by(num_addresses);
};

/*
Expand Down

0 comments on commit 997a29b

Please sign in to comment.