Skip to content

Commit

Permalink
net: ip, raw_diag -- Use jump for exiting from nested loop
Browse files Browse the repository at this point in the history
I managed to miss that sk_for_each is called under "for"
cycle so need to use goto here to return matching socket.

CC: David S. Miller <davem@davemloft.net>
CC: Eric Dumazet <eric.dumazet@gmail.com>
CC: David Ahern <dsa@cumulusnetworks.com>
CC: Andrey Vagin <avagin@openvz.org>
CC: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Cyrill Gorcunov authored and David S. Miller committed Nov 3, 2016
1 parent cd05a0e commit 9999370
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/ipv4/raw_diag.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,11 @@ static struct sock *raw_sock_get(struct net *net, const struct inet_diag_req_v2
* hashinfo->lock here.
*/
sock_hold(sk);
break;
goto out_unlock;
}
}
}
out_unlock:
read_unlock(&hashinfo->lock);

return sk ? sk : ERR_PTR(-ENOENT);
Expand Down

0 comments on commit 9999370

Please sign in to comment.