Skip to content

Commit

Permalink
firmware loader: fix creation failure of fw loader device
Browse files Browse the repository at this point in the history
If one device driver calls request_firmware_nowait() to request
several different firmwares' loading, device_add() will return
failure since all firmware loader device use same name of the
device who is requesting firmware.

This patch always use the name of firmware image as the firmware
loader device name to fix the problem since the following patches
for caching firmware will make sure only one loading for same
firmware is alllowd at the same time.

Signed-off-by: Ming Lei <ming.lei@canonical.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ming Lei authored and Greg Kroah-Hartman committed Aug 16, 2012
1 parent 0c25a85 commit 99c2aa7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/base/firmware_class.c
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
f_dev = &fw_priv->dev;

device_initialize(f_dev);
dev_set_name(f_dev, "%s", dev_name(device));
dev_set_name(f_dev, "%s", fw_name);
f_dev->parent = device;
f_dev->class = &firmware_class;

Expand Down

0 comments on commit 99c2aa7

Please sign in to comment.