Skip to content

Commit

Permalink
PCI/MSI: Reject MSI-X early
Browse files Browse the repository at this point in the history
Similar to PCI multi-MSI reject MSI-X enablement when a irq domain is
attached to the device which does not support MSI-X.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20221111122015.631728309@linutronix.de
  • Loading branch information
Thomas Gleixner committed Nov 17, 2022
1 parent d2a463b commit 99f3d27
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/pci/msi/msi.c
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,10 @@ int __pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries, int
if (WARN_ON_ONCE(dev->msix_enabled))
return -EINVAL;

/* Check MSI-X early on irq domain enabled architectures */
if (!pci_msi_domain_supports(dev, MSI_FLAG_PCI_MSIX, ALLOW_LEGACY))
return -ENOTSUPP;

if (!pci_msi_supported(dev, nvec) || dev->current_state != PCI_D0)
return -EINVAL;

Expand Down

0 comments on commit 99f3d27

Please sign in to comment.