Skip to content

Commit

Permalink
regulator: qcom-labibb: Switch voltage ops from linear_range to linear
Browse files Browse the repository at this point in the history
The LAB and IBB regulator have just one range and it is useless
to use linear_range ops, as these are used to express multiple
linear ranges.

Switch list_voltage and map_voltage callbacks to *_linear instead.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Link: https://lore.kernel.org/r/20210119174421.226541-2-angelogioacchino.delregno@somainline.org
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
AngeloGioacchino Del Regno authored and Mark Brown committed Jan 20, 2021
1 parent f35f6d8 commit 9a12eb7
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions drivers/regulator/qcom-labibb-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ static const struct regulator_ops qcom_labibb_ops = {
.is_enabled = regulator_is_enabled_regmap,
.set_voltage_sel = regulator_set_voltage_sel_regmap,
.get_voltage_sel = regulator_get_voltage_sel_regmap,
.list_voltage = regulator_list_voltage_linear_range,
.map_voltage = regulator_map_voltage_linear_range,
.list_voltage = regulator_list_voltage_linear,
.map_voltage = regulator_map_voltage_linear,
};

static const struct regulator_desc pmi8998_lab_desc = {
Expand All @@ -76,10 +76,8 @@ static const struct regulator_desc pmi8998_lab_desc = {
.off_on_delay = LABIBB_OFF_ON_DELAY,
.owner = THIS_MODULE,
.type = REGULATOR_VOLTAGE,
.linear_ranges = (struct linear_range[]) {
REGULATOR_LINEAR_RANGE(4600000, 0, 15, 100000),
},
.n_linear_ranges = 1,
.min_uV = 4600000,
.uV_step = 100000,
.n_voltages = 16,
.ops = &qcom_labibb_ops,
};
Expand All @@ -97,10 +95,8 @@ static const struct regulator_desc pmi8998_ibb_desc = {
.off_on_delay = LABIBB_OFF_ON_DELAY,
.owner = THIS_MODULE,
.type = REGULATOR_VOLTAGE,
.linear_ranges = (struct linear_range[]) {
REGULATOR_LINEAR_RANGE(1400000, 0, 63, 100000),
},
.n_linear_ranges = 1,
.min_uV = 1400000,
.uV_step = 100000,
.n_voltages = 64,
.ops = &qcom_labibb_ops,
};
Expand Down

0 comments on commit 9a12eb7

Please sign in to comment.