Skip to content

Commit

Permalink
libperf: Adopt perf_counts_values__scale() from tools/perf/util
Browse files Browse the repository at this point in the history
Move perf_counts_values__scale() from tools/perf/util to tools/lib/perf
so that it can be used with libperf.

Committer notes:

As noted by Jiri, use __s8 instead of s8 on the exported function.

Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20211109085831.3770594-2-nakamura.shun@fujitsu.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Shunsuke Nakamura authored and Arnaldo Carvalho de Melo committed Dec 8, 2021
1 parent c77a78c commit 9a5b2d1
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 22 deletions.
19 changes: 19 additions & 0 deletions tools/lib/perf/evsel.c
Original file line number Diff line number Diff line change
Expand Up @@ -431,3 +431,22 @@ void perf_evsel__free_id(struct perf_evsel *evsel)
zfree(&evsel->id);
evsel->ids = 0;
}

void perf_counts_values__scale(struct perf_counts_values *count,
bool scale, __s8 *pscaled)
{
s8 scaled = 0;

if (scale) {
if (count->run == 0) {
scaled = -1;
count->val = 0;
} else if (count->run < count->ena) {
scaled = 1;
count->val = (u64)((double)count->val * count->ena / count->run);
}
}

if (pscaled)
*pscaled = scaled;
}
4 changes: 4 additions & 0 deletions tools/lib/perf/include/perf/evsel.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#include <stdint.h>
#include <perf/core.h>
#include <stdbool.h>
#include <linux/types.h>

struct perf_evsel;
struct perf_event_attr;
Expand Down Expand Up @@ -39,5 +41,7 @@ LIBPERF_API int perf_evsel__disable_cpu(struct perf_evsel *evsel, int cpu);
LIBPERF_API struct perf_cpu_map *perf_evsel__cpus(struct perf_evsel *evsel);
LIBPERF_API struct perf_thread_map *perf_evsel__threads(struct perf_evsel *evsel);
LIBPERF_API struct perf_event_attr *perf_evsel__attr(struct perf_evsel *evsel);
LIBPERF_API void perf_counts_values__scale(struct perf_counts_values *count,
bool scale, __s8 *pscaled);

#endif /* __LIBPERF_EVSEL_H */
1 change: 1 addition & 0 deletions tools/lib/perf/libperf.map
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ LIBPERF_0.0.1 {
perf_mmap__read_init;
perf_mmap__read_done;
perf_mmap__read_event;
perf_counts_values__scale;
local:
*;
};
19 changes: 0 additions & 19 deletions tools/perf/util/evsel.c
Original file line number Diff line number Diff line change
Expand Up @@ -1476,25 +1476,6 @@ void evsel__compute_deltas(struct evsel *evsel, int cpu, int thread,
count->run = count->run - tmp.run;
}

void perf_counts_values__scale(struct perf_counts_values *count,
bool scale, s8 *pscaled)
{
s8 scaled = 0;

if (scale) {
if (count->run == 0) {
scaled = -1;
count->val = 0;
} else if (count->run < count->ena) {
scaled = 1;
count->val = (u64)((double) count->val * count->ena / count->run);
}
}

if (pscaled)
*pscaled = scaled;
}

static int evsel__read_one(struct evsel *evsel, int cpu, int thread)
{
struct perf_counts_values *count = perf_counts(evsel->counts, cpu, thread);
Expand Down
3 changes: 0 additions & 3 deletions tools/perf/util/evsel.h
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,6 @@ static inline int evsel__nr_cpus(struct evsel *evsel)
return evsel__cpus(evsel)->nr;
}

void perf_counts_values__scale(struct perf_counts_values *count,
bool scale, s8 *pscaled);

void evsel__compute_deltas(struct evsel *evsel, int cpu, int thread,
struct perf_counts_values *count);

Expand Down

0 comments on commit 9a5b2d1

Please sign in to comment.