Skip to content

Commit

Permalink
Merge branch 'bugfix' of git://git.kernel.org/pub/scm/linux/kernel/gi…
Browse files Browse the repository at this point in the history
…t/jeremy/xen

* 'bugfix' of git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen:
  xen: mask extended topology info in cpuid
  xen/hvc: make sure console output is always emitted, with explicit polling
  • Loading branch information
Linus Torvalds committed Nov 5, 2009
2 parents d4116f8 + 82d6469 commit 9a6fc8d
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 2 deletions.
11 changes: 10 additions & 1 deletion arch/x86/xen/enlighten.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,16 +178,24 @@ static __read_mostly unsigned int cpuid_leaf1_ecx_mask = ~0;
static void xen_cpuid(unsigned int *ax, unsigned int *bx,
unsigned int *cx, unsigned int *dx)
{
unsigned maskebx = ~0;
unsigned maskecx = ~0;
unsigned maskedx = ~0;

/*
* Mask out inconvenient features, to try and disable as many
* unsupported kernel subsystems as possible.
*/
if (*ax == 1) {
switch (*ax) {
case 1:
maskecx = cpuid_leaf1_ecx_mask;
maskedx = cpuid_leaf1_edx_mask;
break;

case 0xb:
/* Suppress extended topology stuff */
maskebx = 0;
break;
}

asm(XEN_EMULATE_PREFIX "cpuid"
Expand All @@ -197,6 +205,7 @@ static void xen_cpuid(unsigned int *ax, unsigned int *bx,
"=d" (*dx)
: "0" (*ax), "2" (*cx));

*bx &= maskebx;
*cx &= maskecx;
*dx &= maskedx;
}
Expand Down
25 changes: 24 additions & 1 deletion drivers/char/hvc_xen.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ static inline void notify_daemon(void)
notify_remote_via_evtchn(xen_start_info->console.domU.evtchn);
}

static int write_console(uint32_t vtermno, const char *data, int len)
static int __write_console(const char *data, int len)
{
struct xencons_interface *intf = xencons_interface();
XENCONS_RING_IDX cons, prod;
Expand All @@ -76,6 +76,29 @@ static int write_console(uint32_t vtermno, const char *data, int len)
return sent;
}

static int write_console(uint32_t vtermno, const char *data, int len)
{
int ret = len;

/*
* Make sure the whole buffer is emitted, polling if
* necessary. We don't ever want to rely on the hvc daemon
* because the most interesting console output is when the
* kernel is crippled.
*/
while (len) {
int sent = __write_console(data, len);

data += sent;
len -= sent;

if (unlikely(len))
HYPERVISOR_sched_op(SCHEDOP_yield, NULL);
}

return ret;
}

static int read_console(uint32_t vtermno, char *buf, int len)
{
struct xencons_interface *intf = xencons_interface();
Expand Down

0 comments on commit 9a6fc8d

Please sign in to comment.