Skip to content

Commit

Permalink
staging: fbtft: Remove reference to fb_blank
Browse files Browse the repository at this point in the history
The field fb_blank in struct backlight_properties is deprecated and
should not be used. Don't output its value in the driver's debug print.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240319093915.31778-6-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org>
  • Loading branch information
Thomas Zimmermann authored and Lee Jones committed Mar 28, 2024
1 parent 6be0fb6 commit 9a7bb61
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
4 changes: 1 addition & 3 deletions drivers/staging/fbtft/fb_ssd1351.c
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,7 @@ static int update_onboard_backlight(struct backlight_device *bd)
struct fbtft_par *par = bl_get_data(bd);
bool on;

fbtft_par_dbg(DEBUG_BACKLIGHT, par,
"%s: power=%d, fb_blank=%d\n",
__func__, bd->props.power, bd->props.fb_blank);
fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s: power=%d\n", __func__, bd->props.power);

on = !backlight_is_blank(bd);
/* Onboard backlight connected to GPIO0 on SSD1351, GPIO1 unused */
Expand Down
5 changes: 2 additions & 3 deletions drivers/staging/fbtft/fbtft-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,8 @@ static int fbtft_backlight_update_status(struct backlight_device *bd)
struct fbtft_par *par = bl_get_data(bd);
bool polarity = par->polarity;

fbtft_par_dbg(DEBUG_BACKLIGHT, par,
"%s: polarity=%d, power=%d, fb_blank=%d\n",
__func__, polarity, bd->props.power, bd->props.fb_blank);
fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s: polarity=%d, power=%d\n", __func__,
polarity, bd->props.power);

if (!backlight_is_blank(bd))
gpiod_set_value(par->gpio.led[0], polarity);
Expand Down

0 comments on commit 9a7bb61

Please sign in to comment.