Skip to content

Commit

Permalink
drm: Optimise power-of-two alignments in drm_mm_scan_add_block()
Browse files Browse the repository at this point in the history
For power-of-two alignments, we can avoid the 64bit divide and do a
simple bitwise add instead.

v2: s/alignment_mask/remainder_mask/

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20161222083641.2691-32-chris@chris-wilson.co.uk
  • Loading branch information
Chris Wilson authored and Daniel Vetter committed Dec 28, 2016
1 parent 0b04d47 commit 9a956b1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
9 changes: 8 additions & 1 deletion drivers/gpu/drm/drm_mm.c
Original file line number Diff line number Diff line change
Expand Up @@ -742,8 +742,12 @@ void drm_mm_scan_init_with_range(struct drm_mm_scan *scan,

scan->mm = mm;

if (alignment <= 1)
alignment = 0;

scan->color = color;
scan->alignment = alignment;
scan->remainder_mask = is_power_of_2(alignment) ? alignment - 1 : 0;
scan->size = size;
scan->flags = flags;

Expand Down Expand Up @@ -811,7 +815,10 @@ bool drm_mm_scan_add_block(struct drm_mm_scan *scan,
if (scan->alignment) {
u64 rem;

div64_u64_rem(adj_start, scan->alignment, &rem);
if (likely(scan->remainder_mask))
rem = adj_start & scan->remainder_mask;
else
div64_u64_rem(adj_start, scan->alignment, &rem);
if (rem) {
adj_start -= rem;
if (scan->flags != DRM_MM_CREATE_TOP)
Expand Down
1 change: 1 addition & 0 deletions include/drm/drm_mm.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ struct drm_mm_scan {

u64 size;
u64 alignment;
u64 remainder_mask;

u64 range_start;
u64 range_end;
Expand Down

0 comments on commit 9a956b1

Please sign in to comment.