Skip to content

Commit

Permalink
Merge branches 'pm-sleep', 'powercap', 'pm-domains' and 'pm-cpufreq'
Browse files Browse the repository at this point in the history
* pm-sleep:
  PM / sleep: Fix test_suspend= command line option

* powercap:
  powercap / RAPL: change domain detection message
  powercap / RAPL: add support for CPU model 0x3f

* pm-domains:
  PM / domains: Make generic_pm_domain.name const

* pm-cpufreq:
  cpufreq: intel_pstate: Remove unneeded variable
  • Loading branch information
Rafael J. Wysocki committed Sep 5, 2014
5 parents 73f517b + 62109b4 + fcdf179 + d07e9c1 + 73f1ae8 commit 9aa4e2f
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 22 deletions.
4 changes: 0 additions & 4 deletions drivers/cpufreq/intel_pstate.c
Original file line number Diff line number Diff line change
Expand Up @@ -708,10 +708,6 @@ static unsigned int intel_pstate_get(unsigned int cpu_num)

static int intel_pstate_set_policy(struct cpufreq_policy *policy)
{
struct cpudata *cpu;

cpu = all_cpu_data[policy->cpu];

if (!policy->cpuinfo.max_freq)
return -ENODEV;

Expand Down
8 changes: 4 additions & 4 deletions drivers/powercap/intel_rapl.c
Original file line number Diff line number Diff line change
Expand Up @@ -953,6 +953,7 @@ static const struct x86_cpu_id rapl_ids[] = {
{ X86_VENDOR_INTEL, 6, 0x3a},/* Ivy Bridge */
{ X86_VENDOR_INTEL, 6, 0x3c},/* Haswell */
{ X86_VENDOR_INTEL, 6, 0x3d},/* Broadwell */
{ X86_VENDOR_INTEL, 6, 0x3f},/* Haswell */
{ X86_VENDOR_INTEL, 6, 0x45},/* Haswell ULT */
/* TODO: Add more CPU IDs after testing */
{}
Expand Down Expand Up @@ -1166,11 +1167,10 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)

for (i = 0; i < RAPL_DOMAIN_MAX; i++) {
/* use physical package id to read counters */
if (!rapl_check_domain(cpu, i))
if (!rapl_check_domain(cpu, i)) {
rp->domain_map |= 1 << i;
else
pr_warn("RAPL domain %s detection failed\n",
rapl_domain_names[i]);
pr_info("Found RAPL domain %s\n", rapl_domain_names[i]);
}
}
rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
if (!rp->nr_domains) {
Expand Down
2 changes: 1 addition & 1 deletion include/linux/pm_domain.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ struct generic_pm_domain {
struct mutex lock;
struct dev_power_governor *gov;
struct work_struct power_off_work;
char *name;
const char *name;
unsigned int in_progress; /* Number of devices being suspended now */
atomic_t sd_count; /* Number of subdomains with power "on" */
enum gpd_status status; /* Current state of the domain */
Expand Down
1 change: 1 addition & 0 deletions kernel/power/power.h
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ extern void swsusp_show_speed(struct timeval *, struct timeval *,

#ifdef CONFIG_SUSPEND
/* kernel/power/suspend.c */
extern const char *pm_labels[];
extern const char *pm_states[];

extern int suspend_devices_and_enter(suspend_state_t state);
Expand Down
2 changes: 1 addition & 1 deletion kernel/power/suspend.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

#include "power.h"

static const char *pm_labels[] = { "mem", "standby", "freeze", };
const char *pm_labels[] = { "mem", "standby", "freeze", NULL };
const char *pm_states[PM_SUSPEND_MAX];

static const struct platform_suspend_ops *suspend_ops;
Expand Down
31 changes: 19 additions & 12 deletions kernel/power/suspend_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,20 +129,20 @@ static int __init has_wakealarm(struct device *dev, const void *data)
* at startup time. They're normally disabled, for faster boot and because
* we can't know which states really work on this particular system.
*/
static suspend_state_t test_state __initdata = PM_SUSPEND_ON;
static const char *test_state_label __initdata;

static char warn_bad_state[] __initdata =
KERN_WARNING "PM: can't test '%s' suspend state\n";

static int __init setup_test_suspend(char *value)
{
suspend_state_t i;
int i;

/* "=mem" ==> "mem" */
value++;
for (i = PM_SUSPEND_MIN; i < PM_SUSPEND_MAX; i++)
if (!strcmp(pm_states[i], value)) {
test_state = i;
for (i = 0; pm_labels[i]; i++)
if (!strcmp(pm_labels[i], value)) {
test_state_label = pm_labels[i];
return 0;
}

Expand All @@ -158,13 +158,21 @@ static int __init test_suspend(void)

struct rtc_device *rtc = NULL;
struct device *dev;
suspend_state_t test_state;

/* PM is initialized by now; is that state testable? */
if (test_state == PM_SUSPEND_ON)
goto done;
if (!pm_states[test_state]) {
printk(warn_bad_state, pm_states[test_state]);
goto done;
if (!test_state_label)
return 0;

for (test_state = PM_SUSPEND_MIN; test_state < PM_SUSPEND_MAX; test_state++) {
const char *state_label = pm_states[test_state];

if (state_label && !strcmp(test_state_label, state_label))
break;
}
if (test_state == PM_SUSPEND_MAX) {
printk(warn_bad_state, test_state_label);
return 0;
}

/* RTCs have initialized by now too ... can we use one? */
Expand All @@ -173,13 +181,12 @@ static int __init test_suspend(void)
rtc = rtc_class_open(dev_name(dev));
if (!rtc) {
printk(warn_no_rtc);
goto done;
return 0;
}

/* go for it */
test_wakealarm(rtc, test_state);
rtc_class_close(rtc);
done:
return 0;
}
late_initcall(test_suspend);

0 comments on commit 9aa4e2f

Please sign in to comment.